Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send back entire API schema to clients after validation failures #236

Merged
merged 1 commit into from
Jul 22, 2016
Merged

Don't send back entire API schema to clients after validation failures #236

merged 1 commit into from
Jul 22, 2016

Conversation

jvinet
Copy link

@jvinet jvinet commented Jun 1, 2016

Fixes #234 .

Changes proposed in this pull request:

  • For request body validations, instead of sending back the entire API schema, Connexion will only send back the error message (eg: "'value' is a required property"
  • For response validations, Connexion will continue to log the entire API schema via the logger.error call, as it did before.

@rafaelcaricio
Copy link
Collaborator

Thank you for the PR. Could you please add a simple test for that?

@marcos-diaz
Copy link

Please make this move forward. Makes no sense to spam production logs with full schemas.

@coveralls
Copy link

coveralls commented Jul 21, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling c80e1d3 on jvinet:master into a83598d on zalando:master.

@rafaelcaricio
Copy link
Collaborator

👍

1 similar comment
@jmcs
Copy link
Contributor

jmcs commented Jul 22, 2016

👍

@jmcs jmcs merged commit 0e4c601 into spec-first:master Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jvinet @rafaelcaricio @marcos-diaz @coveralls @jmcs